Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use header for credentials everywhere #754

Merged
merged 2 commits into from
Jan 24, 2023
Merged

Use header for credentials everywhere #754

merged 2 commits into from
Jan 24, 2023

Conversation

therve
Copy link
Contributor

@therve therve commented Jan 23, 2023

All endpoint supports it now, let's use headers everywhere.

Requirements for Contributing to this repository

  • Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • The pull request must only fix one issue, or add one feature, at the time.
  • The pull request must update the test suite to demonstrate the changed functionality.
  • After you create the pull request, all status checks must be pass before a maintainer reviews your contribution. For more details, please see CONTRIBUTING.

What does this PR do?

Description of the Change

Alternate Designs

Possible Drawbacks

Verification Process

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

All endpoint supports it now, let's use headers everywhere.
@therve therve added the changelog/Changed Changed features results into a major version bump label Jan 23, 2023
@therve therve requested a review from a team as a code owner January 23, 2023 08:17
@therve
Copy link
Contributor Author

therve commented Jan 23, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@therve therve merged commit 76d3519 into master Jan 24, 2023
@therve therve deleted the therve/key-headers branch January 24, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/Changed Changed features results into a major version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants